Skip to content

Add a brief sleep before sending SIGINT to children #13018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

Add a brief sleep before sending SIGINT to children #13018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/uv/src/commands/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@ pub(crate) async fn run_to_completion(mut handle: Child) -> anyhow::Result<ExitS
continue;
}

debug!("Received SIGINT, forwarding to child at {child_pid}");
// The shell may still be forwarding these signals, give the child a moment to
// handle that signal before hitting it with another one
debug!("Received SIGINT, forwarding to child at {child_pid} in 200ms");
tokio::time::sleep(std::time::Duration::from_millis(200)).await;
let _ = signal::kill(child_pid, signal::Signal::SIGINT);
},
_ = sigterm_handle.recv() => {
Expand Down
Loading