Add tests for uv python list
#12931
Add tests for uv python list
#12931
Conversation
j178
force-pushed
the
list-only-downloads-all-arches
branch
4 times, most recently
from
1bd5b12 to
da51176
Compare
I added a subset of the Python downloads metadata json file for tests. This PR also fixes a issue where using `--only-downloads` with `--all-arches`, `--all-arches` is not honored.
j178
force-pushed
the
list-only-downloads-all-arches
branch
from
da51176 to
91137f2
Compare
| @@ -0,0 +1,674 @@ | |||
| { | |||
There was a problem hiding this comment.
Ah I see it's being used for the test case. Interesting 🤔 I'm worried about maintaining these. Do we need a subset? If so, should it be much smaller? Can you say more about the choice?
There was a problem hiding this comment.
I think we need a fixed subset to keep things stable; otherwise, the tests fall apart every time we sync the latest Python versions.
So, I’m making sure the subset includes a prerelease, a freethreaded variant, different patch versions of the same minor version, and different minor versions. This way, we’ve got a pretty thorough test case.
There was a problem hiding this comment.
Hm.
I'm not sure if I mind if the snapshots need updating when the available versions change.
My concern is that the snapshot doesn't capture the reality for most users, which makes it less valuable and more likely for us to accidentally ship regressions.
| } else if all_arches { | ||
| base_download_request.fill_platform()?.with_any_arch() |
There was a problem hiding this comment.
Generally, it'd be better to do this separately so it can be listed in the changelog.
There was a problem hiding this comment.
Extracted it to #12953
j178
force-pushed
the
list-only-downloads-all-arches
branch
from
91137f2 to
b580da0
Compare
j178
force-pushed
the
list-only-downloads-all-arches
branch
from
b580da0 to
d1ce394
Compare
|
Note this overlaps with #12381 which I forgot to follow-up on after #12381 (comment). |
3 participants
Summary
I added a subset of the Python downloads metadata json file for tests.
This PR also fixes a issue where using--only-downloadswith--all-arches,--all-archesis not honored.