`uv sync` should not emit "DEBUG Removing existing directory due to `--clear`" message

[zanieb]

This message is confusing in uv sync, because... --clear isn't provided, that's jut the default uv sync behavior.

This may require adding an optional Option<OnExistingSource> enum to the OnExisting type so we can differentiate between OnExisting::Remove(Some(OnExistingSource::ClearFlag)) and OnExisting::Remove(None). We'd also be able to differentiate between OneExistingSource::ClearEnv if we wanted? I'm not sure if this is the best approach, just an option.

[vkreddy]

@zanieb can I look into this one?

[yuri-potatoq]

Hey. Am i missing something? I downloaded the project and didn't find the message when running the command provided (even with verbose mode).
The only mention to a message similar to that was here.

[zanieb]

@vkreddy no need to ask permission, feel free.

The message is emitted at

uv/crates/uv-virtualenv/src/virtualenv.rs

Line 111 in bfb4bc2

debug!("Removing existing {name} due to `--clear`");

I'm actually not sure what code path triggers the message. I saw it, but I might have refactored things in a way that makes it impossible from uv sync. We'd need to be removing an existing environment, but we usually will remove it manually ahead of time at

uv/crates/uv/src/commands/project/mod.rs

Lines 1382 to 1396 in 6856a27

	// Remove the existing virtual environment if it doesn't meet the requirements.
	if replace {
	match remove_virtualenv(&root) {
	Ok(()) => {
	writeln!(
	printer.stderr(),
	"Removed virtual environment at: {}",
	root.user_display().cyan()
	)?;
	}
	Err(uv_virtualenv::Error::Io(err))
	if err.kind() == std::io::ErrorKind::NotFound => {}
	Err(err) => return Err(err.into()),
	}
	}

during sync operations.

[zanieb]

This may be resolved, I guess I should have included logs of what I was doing 😬

If nobody sees a clear way to hit that code path I shared, we could close this out for now. The problem still exists though, it'll probably be annoying in the future so if someone is interested it's probably still worth changing?