--offline is not offline for "git+https" sources.

[konstin]

Originally posted by @andrei-korshikov in #942

I'm on uv 0.6.6 (c1a0bb8 2025-03-12). Some of my dependencies are git+https, e.g. I have

# /// script
# dependencies = [
#   "pycurl @ git+https://github.com/pycurl/pycurl.git",
#   ]
# ///

On every run of uv run --offline my_script.py I see Resolving dependencies... message and get these messages on stderr (and see corresponding traffic in Wireshark):

Updating https://github.com/pycurl/pycurl.git (HEAD)
Updated https://github.com/pycurl/pycurl.git (d92395d9fe1e18365c4e4812f4351bd6985872e1)

If this behaviour is intended, I think it should be documented. Documentation for --offline reads: "Disable network access. When disabled, uv will only use locally cached data and locally available files.", and as we see for "git+https" it is definitely not so.

---

Off-topic: and huge thank you for uv!:)

[charliermarsh]

Yeah this seems like an oversight.

(As an aside, Updated https://github.com/pycurl/pycurl.git (d92395d9fe1e18365c4e4812f4351bd6985872e1) on its own does not always mean that we've made a network request. We show that even when checking out an already-available commit locally. But if the user is seeing Wireshark traffic then it does sound like a bug.)

[andrei-korshikov]

But if the user is seeing Wireshark traffic then it does sound like a bug.

Just for clarification. --offline without Internet access:

% uv run --offline --script sync.py
   Updating https://github.com/pycurl/pycurl.git (HEAD)
  × Failed to download and build `pycurl @ git+https://github.com/pycurl/pycurl.git`
  ├─▶ Git operation failed
  ├─▶ failed to fetch into: /home/korshikov/.cache/uv/git-v0/db/9a596e5213c3162d
  ╰─▶ process didn't exit successfully: `/usr/bin/git fetch --force --update-head-ok 'https://github.com/pycurl/pycurl.git' '+HEAD:refs/remotes/origin/HEAD'` (exit status: 128)
      --- stderr
      fatal: unable to access 'https://github.com/pycurl/pycurl.git/': Could not resolve host: github.com

[charliermarsh]

I think we can set GIT_ALLOW_PROTOCOL=file (https://git-scm.com/docs/git)

[thejchap]

I'll take a look at this one