Skip to content

New rule: Prevent assignment expressions in assert statements #7856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 9, 2023
Merged

New rule: Prevent assignment expressions in assert statements #7856

merged 7 commits into from
Oct 9, 2023

Conversation

@harupy
Copy link
Contributor

@harupy harupy commented Oct 9, 2023

Summary

Close #7205

Test Plan

cargo test

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@konstin konstin requested a review from charliermarsh October 9, 2023 07:52
@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Oct 9, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) October 9, 2023 18:56
@charliermarsh charliermarsh merged commit 7faa431 into astral-sh:main Oct 9, 2023
@harupy harupy deleted the assign-in-assert branch October 10, 2023 00:43
konstin pushed a commit that referenced this pull request Oct 11, 2023
@harupy @konstin
New rule: Prevent assignment expressions in assert statements (#7856)
bbd2666
@p-linnane p-linnane mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konstin konstin konstin approved these changes

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees

No one assigned

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule suggestion: Prevent walrus assignments in assert statements

3 participants

@harupy @konstin @charliermarsh