Show custom message for Path.joinpath with starred arguments
#7852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+7, -7, 0 error(s)) airflow (+4, -4)
+ airflow/providers/google/cloud/transfers/sql_to_gcs.py:492:27: PTH118 `os.path.join()` should be replaced by `Path.joinpath()` - airflow/providers/google/cloud/transfers/sql_to_gcs.py:492:27: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator + dev/provider_packages/prepare_provider_packages.py:281:12: PTH118 `os.path.join()` should be replaced by `Path.joinpath()` - dev/provider_packages/prepare_provider_packages.py:281:12: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator + dev/provider_packages/prepare_provider_packages.py:833:12: PTH118 `os.path.join()` should be replaced by `Path.joinpath()` - dev/provider_packages/prepare_provider_packages.py:833:12: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator + dev/provider_packages/prepare_provider_packages.py:851:29: PTH118 `os.path.join()` should be replaced by `Path.joinpath()` - dev/provider_packages/prepare_provider_packages.py:851:29: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator bokeh (+1, -1)
+ src/bokeh/util/compiler.py:525:36: PTH118 `os.path.join()` should be replaced by `Path.joinpath()` - src/bokeh/util/compiler.py:525:36: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator zulip (+2, -2)
+ tools/documentation_crawler/documentation_crawler/spiders/check_documentation.py:12:19: PTH118 `os.path.join()` should be replaced by `Path.joinpath()` - tools/documentation_crawler/documentation_crawler/spiders/check_documentation.py:12:19: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator + tools/documentation_crawler/documentation_crawler/spiders/check_help_documentation.py:12:42: PTH118 `os.path.join()` should be replaced by `Path.joinpath()` - tools/documentation_crawler/documentation_crawler/spiders/check_help_documentation.py:12:42: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator
|
konstin
approved these changes
Oct 9, 2023
| format!("`os.{module}.join()` should be replaced by `Path` with `/` operator") | ||
| } | ||
| Joiner::Joinpath => { | ||
| format!("`os.{module}.join()` should be replaced by `Path.joinpath`") |
There was a problem hiding this comment.
Suggested change
| format!("`os.{module}.join()` should be replaced by `Path.joinpath`") | |
| format!("`os.{module}.join()` should be replaced by `Path.joinpath()`") |
charliermarsh
force-pushed
the
charlie/join
branch
from
3458717 to
3319b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7833.