Skip to content

Conversation

@tjkuson
Copy link
Contributor

@tjkuson tjkuson commented Oct 2, 2023

Summary

Closes #7636.

Test Plan

cargo test

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 2, 2023

CodSpeed Performance Report

Merging #7768 will degrade performances by 2.37%

Comparing tjkuson:star-starmap (b890639) with main (f872c3b)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main tjkuson:star-starmap Change
linter/default-rules[pydantic/types.py] 38 ms 38.9 ms -2.37%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@tjkuson tjkuson marked this pull request as ready for review October 2, 2023 22:21
@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Oct 3, 2023
@charliermarsh charliermarsh merged commit e129f77 into astral-sh:main Oct 3, 2023
@tjkuson tjkuson deleted the star-starmap branch October 3, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement on reimplemented-starmap rule (FURB140)

2 participants