[ty] Respect dataclass_transform parameters for metaclass-based models
#20780
+151
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
commented
Oct 9, 2025
|
|
||
| let has_dataclass_param = |param| { | ||
| dataclass_params.is_some_and(|params| params.contains(param)) | ||
| || transformer_params.is_some_and(|params| params.contains(param)) |
There was a problem hiding this comment.
This is the key part: we also fall back to the dataclass_transform parameters, if necessary.
Diagnostic diff on typing conformance testsChanges were detected when running ty on typing conformance tests--- old-output.txt 2025-10-09 13:21:29.281810829 +0000
+++ new-output.txt 2025-10-09 13:21:32.604839205 +0000
@@ -292,8 +292,12 @@
dataclasses_transform_func.py:77:36: error[invalid-return-type] Function always implicitly returns `None`, which is not assignable to return type `T@create_model_frozen`
dataclasses_transform_func.py:97:1: error[invalid-assignment] Property `id` defined in `Customer3` is read-only
dataclasses_transform_meta.py:60:36: error[unknown-argument] Argument `other_name` does not match any known parameter
+dataclasses_transform_meta.py:66:18: error[too-many-positional-arguments] Too many positional arguments: expected 0, got 2
dataclasses_transform_meta.py:73:6: error[unsupported-operator] Operator `<` is not supported for types `Customer1` and `Customer1`
dataclasses_transform_meta.py:79:6: error[unsupported-operator] Operator `<` is not supported for types `Customer2` and `Customer2`
+dataclasses_transform_meta.py:83:8: error[missing-argument] No argument provided for required parameter `id`
+dataclasses_transform_meta.py:83:18: error[too-many-positional-arguments] Too many positional arguments: expected 0, got 2
+dataclasses_transform_meta.py:103:1: error[invalid-assignment] Property `id` defined in `Customer3` is read-only
dataclasses_usage.py:50:6: error[missing-argument] No argument provided for required parameter `unit_price`
dataclasses_usage.py:51:28: error[invalid-argument-type] Argument is incorrect: Expected `int | float`, found `Literal["price"]`
dataclasses_usage.py:52:36: error[too-many-positional-arguments] Too many positional arguments: expected 3, got 4
@@ -896,5 +900,5 @@
typeddicts_usage.py:28:17: error[missing-typed-dict-key] Missing required key 'name' in TypedDict `Movie` constructor
typeddicts_usage.py:28:18: error[invalid-key] Invalid key access on TypedDict `Movie`: Unknown key "title"
typeddicts_usage.py:40:24: error[invalid-type-form] The special form `typing.TypedDict` is not allowed in type expressions. Did you mean to use a concrete TypedDict or `collections.abc.Mapping[str, object]` instead?
-Found 897 diagnostics
+Found 901 diagnostics
WARN A fatal error occurred while checking some files. Not all project files were analyzed. See the diagnostics list above for details. |
|
|
sharkdp
force-pushed
the
david/dataclass_transform-params-for-metaclass-models
branch
from
ee1ea52 to
60daff8
Compare
sharkdp
force-pushed
the
david/dataclass_transform-params-for-metaclass-models
branch
from
60daff8 to
755c692
Compare
sharkdp
force-pushed
the
david/dataclass_transform-params-for-metaclass-models
branch
from
755c692 to
1ee1dea
Compare
AlexWaygood
approved these changes
Oct 9, 2025
crates/ty_python_semantic/resources/mdtest/dataclasses/dataclass_transform.md
Outdated
Show resolved
Hide resolved
crates/ty_python_semantic/resources/mdtest/dataclasses/dataclass_transform.md
Outdated
Show resolved
Hide resolved
crates/ty_python_semantic/resources/mdtest/dataclasses/dataclass_transform.md
Outdated
Show resolved
Hide resolved
sharkdp
deleted the
david/dataclass_transform-params-for-metaclass-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Respect parameters such as
frozen_defaultfor metaclass-based@dataclass_transformermodels.Related to: astral-sh/ty#1260
Typing conformance changes
Those are all correct (new true positives)
Test Plan
New Markdown tests