Skip to content

Conversation

danparizher
Copy link
Contributor

Summary

Fixes #20609

@danparizher danparizher changed the title [cli] Add conflict between --add-noqa and --diff options [cli] Add conflict between --add-noqa and --diff options Sep 29, 2025
@danparizher
Copy link
Contributor Author

I'm not sure if we even want a test for conflicts like this, as I haven't seen any other tests similar to it. Let me know if we want it removed.

Copy link
Contributor

github-actions bot commented Sep 30, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@danparizher
Copy link
Contributor Author

Actually, I can see that the executable in the CI has different syntax depending on the OS, so I'll just remove the test.

@MichaReiser MichaReiser added bug Something isn't working fixes Related to suggested fixes for violations labels Sep 30, 2025
@MichaReiser MichaReiser merged commit 1c08f71 into astral-sh:main Sep 30, 2025
38 checks passed
@danparizher danparizher deleted the fix-20609 branch September 30, 2025 10:57
dcreager added a commit that referenced this pull request Sep 30, 2025
* main: (21 commits)
  [ty] Literal promotion refactor (#20646)
  [ty] Add tests for nested generic functions (#20631)
  [`cli`] Add conflict between `--add-noqa` and `--diff` options (#20642)
  [ty] Ensure first-party search paths always appear in a sensible order (#20629)
  [ty] Use `typing.Self` for the first parameter of instance methods (#20517)
  [ty] Remove unnecessary `parsed_module()` calls (#20630)
  Remove `TextEmitter` (#20595)
  [ty] Use fully qualified names to distinguish ambiguous protocols in diagnostics (#20627)
  [ty] Ecosystem analyzer: relax timeout thresholds (#20626)
  [ty] Apply type mappings to functions eagerly (#20596)
  [ty] Improve disambiguation of class names in diagnostics (#20603)
  Add the *The Basics* title back to CONTRIBUTING.md (#20624)
  [`playground`] Fix quick fixes for empty ranges in playground (#20599)
  Update dependency ruff to v0.13.2 (#20622)
  [`ruff`] Fix minor typos in doc comments (#20623)
  Update dependency PyYAML to v6.0.3 (#20621)
  Update cargo-bins/cargo-binstall action to v1.15.6 (#20620)
  Fixed documentation for try_consider_else (#20587)
  [ty] Use `Top` materializations for `TypeIs` special form (#20591)
  [ty] Simplify `Any | (Any & T)` to `Any` (#20593)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fixes Related to suggested fixes for violations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

warning: --fix is incompatible with --add-noqa when using --diff

2 participants