[ruff] Fix panic when comments appear between unary operators and operands
#20494
+100
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19226
Fixes a panic in binary expression formatting caused by TextRange assertion failures when comments are positioned between unary operators (like
not) and their operands.The issue occurred because
expression.start()points to the unary operator whilecomment.end()can be positioned after it, creating invalid TextRange where start > end. The fix usesoperand.start()for unary operations to ensure proper ordering.Test Plan
I have added new test cases to
crates/ruff_python_formatter/resources/test/fixtures/ruff/expression/unary.py.