Skip to content

Conversation

TaKO8Ki
Copy link
Contributor

@TaKO8Ki TaKO8Ki commented Sep 16, 2025

Summary

Fixes #19015

Switch ruff_wasm to pass Flags::from_settings, matching CLI/server behavior. This enables NOQA flag.

pub struct Flags: u8 {

Test Plan

I've confirmed that it works in my local environemt. If it's necessary to add other test, please let me know.

スクリーンショット 2025-09-17 045233

Copy link
Contributor

github-actions bot commented Sep 16, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@TaKO8Ki TaKO8Ki force-pushed the playground-noqa-multiline branch from 93c600d to e363c4e Compare September 16, 2025 20:26
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@MichaReiser MichaReiser added the playground A playground-specific issue label Sep 17, 2025
@MichaReiser MichaReiser merged commit 98071b4 into astral-sh:main Sep 17, 2025
68 of 69 checks passed
@TaKO8Ki TaKO8Ki deleted the playground-noqa-multiline branch September 17, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playground A playground-specific issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[playground] noqa range in playground disagrees with CLI and server for multiline strings
2 participants