[ty] Benchmarks for problematic implicit instance attributes cases #20133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
added
internal
sharkdp
commented
Aug 28, 2025
Comment on lines
-453
to
-454
| self.a = "" | ||
| self.b = "" |
There was a problem hiding this comment.
Apparently something changed here, because previously it was able to reproduce this with the attributes at the beginning of the method. Now it only seems to reproduce if they are defined at the end, after all returns.
sharkdp
commented
Aug 28, 2025
Comment on lines
+466
to
+469
| if isinstance(self.b, str): | ||
| return | ||
| if isinstance(self.b, str): | ||
| return |
There was a problem hiding this comment.
We reduced this so much that it wasn't actually showing a problematic runtime anymore. So I added two more clauses.
CodSpeed Instrumentation Performance ReportMerging #20133 will degrade performances by 34.43%Comparing Summary
Benchmarks breakdown
|
|
AlexWaygood
approved these changes
Aug 28, 2025
dcreager
added a commit
that referenced
this pull request
Aug 28, 2025
* main: Fix mdtest ignore python code blocks (#20139) [ty] add support for cyclic legacy generic protocols (#20125) [ty] add cycle detection for find_legacy_typevars (#20124) Use new diff rendering format in tests (#20101) [ty] Fix 'too many cycle iterations' for unions of literals (#20137) [ty] No boundness analysis for implicit instance attributes (#20128) Bump 0.12.11 (#20136) [ty] Benchmarks for problematic implicit instance attributes cases (#20133) [`pyflakes`] Fix `allowed-unused-imports` matching for top-level modules (`F401`) (#20115) Move GitLab output rendering to `ruff_db` (#20117) [ty] Evaluate reachability of non-definitely-bound to Ambiguous (#19579) [ty] Introduce a representation for the top/bottom materialization of an invariant generic (#20076) [`flake8-async`] Implement `blocking-http-call-httpx` (`ASYNC212`) (#20091) [ty] print diagnostics with fully qualified name to disambiguate some cases (#19850) [`ruff`] Preserve relative whitespace in multi-line expressions (`RUF033`) (#19647)
second-ed
pushed a commit
to second-ed/ruff
that referenced
this pull request
Sep 9, 2025
…stral-sh#20133) ## Summary Add regression benchmarks for the problematic cases in astral-sh/ty#758. I'd like to merge this before astral-sh#20128 to measure the impact (local tests show that this will "solve" both cases).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add regression benchmarks for the problematic cases in astral-sh/ty#758. I'd like to merge this before #20128 to measure the impact (local tests show that this will "solve" both cases).