[ty] Add Top[] and Bottom[] special forms, replacing top_materialization_of() function #20054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion_of() function Part of astral-sh#994
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
JelleZijlstra
requested review from
AlexWaygood,
MichaReiser,
carljm,
dcreager and
sharkdp
as code owners
|
second-ed
pushed a commit
to second-ed/ruff
that referenced
this pull request
Sep 9, 2025
…ion_of() function (astral-sh#20054) Part of astral-sh/ty#994 ## Summary Add new special forms to `ty_extensions`, `Top[T]` and `Bottom[T]`. Remove `ty_extensions.top_materialization` and `ty_extensions.bottom_materialization`. ## Test Plan Converted the existing `materialization.md` mdtest to the new syntax. Added some tests for invalid use of the new special form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of astral-sh/ty#994
Summary
Add new special forms to
ty_extensions,Top[T]andBottom[T]. Removety_extensions.top_materializationandty_extensions.bottom_materialization.Test Plan
Converted the existing
materialization.mdmdtest to the new syntax. Added some tests for invalid use of the new special form.