[ty] Fix static assertion size check #19814
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
requested review from
carljm,
AlexWaygood,
sharkdp and
dcreager
as code owners
BurntSushi
requested review from
MichaReiser and
dylwil3
and removed request for
dcreager,
carljm,
sharkdp and
AlexWaygood
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
dylwil3
reviewed
Aug 7, 2025
A `Segment` has a `Box` in it, which has a platform dependent size. Adjust the check to be conditional on the pointer size.
BurntSushi
force-pushed
the
ag/fix-member
branch
from
c313dee to
50f708a
Compare
dylwil3
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
Segmenthas aBoxin it, which has a platform dependent size.Restrict the check to only 64-bit targets.