Skip to content

[pylint] Mark PLC0207 fixes as unsafe when *args unpacking is present #19679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 6, 2025
Merged

[pylint] Mark PLC0207 fixes as unsafe when *args unpacking is present #19679

merged 3 commits into from
Aug 6, 2025
+59 −7

Conversation

danparizher
Copy link
Contributor

Summary

Fixes #19660

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre ntBre added bug Something isn't working fixes Related to suggested fixes for violations labels Aug 1, 2025
ntBre
ntBre approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The code fix looks perfect to me, just a couple of docs nits and a question/suggestion about tests.

dylwil3
dylwil3 approved these changes Aug 1, 2025
View reviewed changes
Copy link
Collaborator

@dylwil3 dylwil3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Edit: whoops, didn't see Brent reviewing - and being more helpful and discerning 😅

@danparizher danparizher requested a review from ntBre August 1, 2025 21:44
ntBre
ntBre approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@ntBre ntBre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ntBre ntBre merged commit 745742e into astral-sh:main Aug 6, 2025
35 checks passed
@danparizher danparizher deleted the fix-19660 branch August 6, 2025 18:27
@BrewTestBot BrewTestBot mentioned this pull request Aug 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntBre ntBre ntBre approved these changes

@dylwil3 dylwil3 dylwil3 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

* unpacking should make PLC0207 fix unsafe
3 participants
@danparizher @ntBre @dylwil3