[pyupgrade] Remove non-pep604-isinstance (UP038)
#19156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
breaking
|
Thanks. Unfortunately we won't be able to merge this until the next minor release (v0.13), as it's a breaking change. |
AlexWaygood
reviewed
Jul 5, 2025
|
no worries Thanks for letting me know I will fix these failing CI |
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| UP038 | 1 | 0 | 1 | 0 | 0 |
Linter (preview)
✅ ecosystem check detected no linter changes.
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
AlexWaygood
requested changes
Jul 7, 2025
There was a problem hiding this comment.
Rather than removing the rule implementation at all, I think we just want to change the category of the rule to Removed, similar to the changes we made to S320 in #18617. That way it doesn't break the configuration setup of lots of projects. (We can see the effect it currently has from the ecosystem report)
|
sounds good me 👍 doing it |
AlexWaygood
previously requested changes
Jul 7, 2025
...uff_linter/src/rules/pyupgrade/snapshots/ruff_linter__rules__pyupgrade__tests__UP038.py.snap
Show resolved
Hide resolved
|
Wait, the changes you previously had applied to |
|
give me 2 mins i am reverting snapshots too i need to do that locally |
AlexWaygood
reviewed
Jul 7, 2025
Co-authored-by: Alex Waygood <[email protected]>
|
Thanks! I made alot of mistakes here but i am unable to discard snapshot changes |
|
This looks good to me now, but we'll still need to wait for the v0.13 release before merging it :-) |
ntBre
approved these changes
Sep 5, 2025
crates/ruff_linter/src/rules/pyupgrade/rules/use_pep604_isinstance.rs
Outdated
Show resolved
Hide resolved
ntBre
changed the title
pyupgrade] Remove non-pep604-isinstance (UP038)
ntBre
added a commit
that referenced
this pull request
Sep 8, 2025
## Summary This PR Removes deprecated UP038 as per instructed in #18727 closes #18727 ## Test Plan I have run tests non of them failing One Question i have is do we have to document that UP038 is removed? --------- Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Brent Westbrook <[email protected]>
ntBre
added
rule
ntBre
added a commit
that referenced
this pull request
Sep 10, 2025
## Summary This PR Removes deprecated UP038 as per instructed in #18727 closes #18727 ## Test Plan I have run tests non of them failing One Question i have is do we have to document that UP038 is removed? --------- Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Brent Westbrook <[email protected]>
ntBre
added a commit
that referenced
this pull request
Sep 10, 2025
## Summary This PR Removes deprecated UP038 as per instructed in #18727 closes #18727 ## Test Plan I have run tests non of them failing One Question i have is do we have to document that UP038 is removed? --------- Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Brent Westbrook <[email protected]>
ntBre
added a commit
that referenced
this pull request
Sep 10, 2025
## Summary This PR Removes deprecated UP038 as per instructed in #18727 closes #18727 ## Test Plan I have run tests non of them failing One Question i have is do we have to document that UP038 is removed? --------- Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Brent Westbrook <[email protected]>
dcreager
added a commit
that referenced
this pull request
Sep 10, 2025
* main: (26 commits) Ignore deprecated rules unless selected by exact code (#20167) Stabilize adding future import via config option (#20277) [`flake8-errmsg`] Stabilize extending `raw-string-in-exception` (`EM101`) to support byte strings (#20273) Stabilize the remaining Airflow rules (#20250) [`flake8-bugbear`] Stabilize support for non-context-manager calls in `assert-raises-exception` (`B017`) (#20274) [`flake8-commas`] Stabilize support for trailing comma checks in type parameter lists (`COM812`, `COM819`) (#20275) [`pygrep_hooks`] Stabilize using`AsyncMock` methods in `invalid-mock-access` (`PGH005`) (#20272) Stabilize new strategy for classifying imports as first party (#20268) [`pylint`] Stabilize ignoring `__init__.py` for `useless-import-alias` (`PLC0414`) (#20271) [`pylint`] Stabilize adding U+061C to `bidirectional-unicode` (`PLE2502`) (#20276) [`flake8-simplify`] Stabilize fix safety of `multiple-with-statements` (`SIM117`) (#20270) Stabilize `pytest-raises-ambiguous-pattern` (`RUF043`) (#20253) Stabilize `f-string-number-format` (`FURB116`) (#20247) [`pyupgrade`] Remove `non-pep604-isinstance` (`UP038`) (#19156) [`pandas-vet`] Remove `pandas-df-variable-name` (`PD901`) (#19223) Remove deprecated macOS config file discovery (#19210) Stabilize `redundant-none-literal` (`PYI061`) (#20236) Stabilize `generic-not-last-base-class` (`PYI059`) (#20246) Stabilize `useless-class-metaclass-type` (`UP050`) (#20230) Stabilize `os-symlink` (`PTH211`) (#20229) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR Removes deprecated UP038 as per instructed in #18727
closes #18727
Test Plan
I have run tests non of them failing
One Question i have is do we have to document that UP038 is removed?