[pyupgrade] Stabilize private-type-parameter (UP049) #18515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These with the funny descriptions are being generated by claude with a lot of hand-holding. I'm double-checking that the tests are in the right place and that the docs look okay manually, but not necessarily before opening the PRs. |
|
lol Claude, I don't think you did... |
|
I actually do have a Makefile and told it to run |
oh whoops! sorry, Claude - my mistake! |
|
Looks like the ecosystem check is all unrelated (claude had the base branch wrong initially again). The docs and tests look good to me. |
dylwil3
approved these changes
Jun 6, 2025
ntBre
force-pushed
the
brent/release-0.12.0
branch
3 times, most recently
from
9252447 to
829acf4
Compare
ntBre
force-pushed
the
brent/stabilize-up049
branch
from
650247d to
4ea8d76
Compare
ntBre
added a commit
that referenced
this pull request
Jun 10, 2025
## Summary Stabilizes the UP049 rule (private-type-parameter) by moving it from Preview to Stable. UP049 detects and fixes the use of private type parameters (those with leading underscores) in PEP 695 generic classes and functions. ## Test plan - Verified that UP049 tests pass: `crates/ruff_linter/src/rules/pyupgrade/mod.rs` - Ran full test suite with `make test` - Confirmed that no test migration was needed as UP049 was already in the main `rules` test function ## Rule documentation https://docs.astral.sh/ruff/rules/private-type-parameter/
ntBre
added a commit
that referenced
this pull request
Jun 11, 2025
## Summary Stabilizes the UP049 rule (private-type-parameter) by moving it from Preview to Stable. UP049 detects and fixes the use of private type parameters (those with leading underscores) in PEP 695 generic classes and functions. ## Test plan - Verified that UP049 tests pass: `crates/ruff_linter/src/rules/pyupgrade/mod.rs` - Ran full test suite with `make test` - Confirmed that no test migration was needed as UP049 was already in the main `rules` test function ## Rule documentation https://docs.astral.sh/ruff/rules/private-type-parameter/
ntBre
added a commit
that referenced
this pull request
Jun 17, 2025
## Summary Stabilizes the UP049 rule (private-type-parameter) by moving it from Preview to Stable. UP049 detects and fixes the use of private type parameters (those with leading underscores) in PEP 695 generic classes and functions. ## Test plan - Verified that UP049 tests pass: `crates/ruff_linter/src/rules/pyupgrade/mod.rs` - Ran full test suite with `make test` - Confirmed that no test migration was needed as UP049 was already in the main `rules` test function ## Rule documentation https://docs.astral.sh/ruff/rules/private-type-parameter/
ntBre
added a commit
that referenced
this pull request
Jun 17, 2025
## Summary Stabilizes the UP049 rule (private-type-parameter) by moving it from Preview to Stable. UP049 detects and fixes the use of private type parameters (those with leading underscores) in PEP 695 generic classes and functions. ## Test plan - Verified that UP049 tests pass: `crates/ruff_linter/src/rules/pyupgrade/mod.rs` - Ran full test suite with `make test` - Confirmed that no test migration was needed as UP049 was already in the main `rules` test function ## Rule documentation https://docs.astral.sh/ruff/rules/private-type-parameter/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stabilizes the UP049 rule (private-type-parameter) by moving it from Preview to Stable.
UP049 detects and fixes the use of private type parameters (those with leading underscores) in PEP 695 generic classes and functions.
Test plan
crates/ruff_linter/src/rules/pyupgrade/mod.rsmake testrulestest functionRule documentation
https://docs.astral.sh/ruff/rules/private-type-parameter/