[ty] Tell the user why we inferred a certain Python version when reporting version-specific syntax errors #18295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rting version-specific syntax errors
AlexWaygood
requested review from
carljm,
sharkdp,
dcreager and
MichaReiser
as code owners
AlexWaygood
added
ty
|
ntBre
approved these changes
May 25, 2025
AlexWaygood
commented
May 25, 2025
AlexWaygood
force-pushed
the
alex/syntax-error-hint
branch
from
0f8f882 to
08db324
Compare
carljm
added a commit
to MatthewMckee4/ruff
that referenced
this pull request
May 28, 2025
* main: (246 commits) [ty] Simplify signature types, use them in `CallableType` (astral-sh#18344) [ty] Support ephemeral uv virtual environments (astral-sh#18335) Add a `ViolationMetadata::rule` method (astral-sh#18234) Return `DiagnosticGuard` from `Checker::report_diagnostic` (astral-sh#18232) [flake8_use_pathlib]: Replace os.symlink with Path.symlink_to (PTH211) (astral-sh#18337) [ty] Support cancellation and retry in the server (astral-sh#18273) [ty] Synthetic function-like callables (astral-sh#18242) [ty] Support publishing diagnostics in the server (astral-sh#18309) Add Autofix for ISC003 (astral-sh#18256) [`pyupgrade`]: new rule UP050 (`useless-class-metaclass-type`) (astral-sh#18334) [pycodestyle] Make `E712` suggestion not assume a context (astral-sh#18328) put similar dunder-call tests next to each other (astral-sh#18343) [ty] Derive `PartialOrd, Ord` for `KnownInstanceType` (astral-sh#18340) [ty] Simplify `Type::try_bool()` (astral-sh#18342) [ty] Simplify `Type::normalized` slightly (astral-sh#18339) [ty] Move arviz off the list of selected primer projects (astral-sh#18336) [ty] Add --config-file CLI arg (astral-sh#18083) [ty] Tell the user why we inferred a certain Python version when reporting version-specific syntax errors (astral-sh#18295) [ty] Implement implicit inheritance from `Generic[]` for PEP-695 generic classes (astral-sh#18283) [ty] Add hint if async context manager is used in non-async with statement (astral-sh#18299) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves our reporting of version-specific syntax errors in ty so that we inform the user why we inferred a certain Python version when parsing Python syntax in their project.
Screenshot demo
## ImplementationI had to add a couple ofAsMutimplementations so that the function adding the subdiagnostic would be able to accept both amut LintDiagnosticGuard(if called from within thety_python_semanticcrate) or amut Diagnostic(if called from within thetycrate). The existingDerefMut<Target=Diagnostic>implementation thatLintDiagnosticGuardhas is insufficient, becauseDiagnosticdoes not (and cannot) implementDerefMut<Target=Diagnostic>. It felt odd addingAsMutimplementations without also addingAsRefimplementations, so I also added these for consistency, although they are not strictly needed.Test Plan
I added a snapshot test to the
tycrate