[airflow] Extract AIR312 from AIR302 rules (AIR302, AIR312)

crates/ruff_linter/resources/test/fixtures/airflow/AIR312.py

@@ -0,0 +1,55 @@
+from __future__ import annotations
+
+from airflow.hooks.filesystem import FSHook
+from airflow.hooks.package_index import PackageIndexHook
+from airflow.hooks.subprocess import SubprocessHook, SubprocessResult, working_directory
+from airflow.operators.bash import BashOperator
+from airflow.operators.datetime import BranchDateTimeOperator, target_times_as_dates
+from airflow.operators.empty import EmptyOperator
+from airflow.operators.latest_only import LatestOnlyOperator
+from airflow.operators.python import (
+    BranchPythonOperator,
+    PythonOperator,
+    PythonVirtualenvOperator,
+    ShortCircuitOperator,
+)
+from airflow.operators.trigger_dagrun import TriggerDagRunLink, TriggerDagRunOperator
+from airflow.operators.weekday import BranchDayOfWeekOperator
+from airflow.sensors.date_time import DateTimeSensor, DateTimeSensorAsync
+from airflow.sensors.external_task import (
+    ExternalTaskMarker,
+    ExternalTaskSensor,
+    ExternalTaskSensorLink,
+)
+from airflow.sensors.filesystem import FileSensor
+from airflow.sensors.time_delta import TimeDeltaSensor, TimeDeltaSensorAsync, WaitSensor
+from airflow.sensors.time_sensor import TimeSensor, TimeSensorAsync
+from airflow.sensors.weekday import DayOfWeekSensor
+from airflow.triggers.external_task import DagStateTrigger, WorkflowTrigger
+from airflow.triggers.file import FileTrigger
+from airflow.triggers.temporal import DateTimeTrigger, TimeDeltaTrigger
+
+FSHook()
+PackageIndexHook()
+SubprocessHook(), SubprocessResult(), working_directory()
+BashOperator()
+BranchDateTimeOperator(), target_times_as_dates()
+TriggerDagRunLink(), TriggerDagRunOperator()
+EmptyOperator()
+LatestOnlyOperator()
+(
+    BranchPythonOperator(),
+    PythonOperator(),
+    PythonVirtualenvOperator(),
+    ShortCircuitOperator(),
+)
+BranchDayOfWeekOperator()
+DateTimeSensor(), DateTimeSensorAsync()
+ExternalTaskMarker(), ExternalTaskSensor(), ExternalTaskSensorLink()
+FileSensor()
+TimeSensor(), TimeSensorAsync()
+TimeDeltaSensor(), TimeDeltaSensorAsync(), WaitSensor()
+DayOfWeekSensor()
+DagStateTrigger(), WorkflowTrigger()
+FileTrigger()
+DateTimeTrigger(), TimeDeltaTrigger()

crates/ruff_linter/src/checkers/ast/analyze/expression.rs

@@ -232,6 +232,9 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
                     if checker.enabled(Rule::Airflow3MovedToProvider) {
                         airflow::rules::moved_to_provider_in_3(checker, expr);
                     }
+                    if checker.enabled(Rule::Airflow3SuggestedToMoveToProvider) {
+                        airflow::rules::suggested_to_move_to_provider_in_3(checker, expr);
+                    }
                     if checker.any_enabled(&[
                         Rule::SuspiciousPickleUsage,
                         Rule::SuspiciousMarshalUsage,
@@ -448,6 +451,9 @@ pub(crate) fn expression(expr: &Expr, checker: &Checker) {
             if checker.enabled(Rule::Airflow3Removal) {
                 airflow::rules::airflow_3_removal_expr(checker, expr);
             }
+            if checker.enabled(Rule::Airflow3SuggestedToMoveToProvider) {
+                airflow::rules::suggested_to_move_to_provider_in_3(checker, expr);
+            }
         }
         Expr::Call(
             call @ ast::ExprCall {

crates/ruff_linter/src/codes.rs

@@ -1072,6 +1072,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Airflow, "002") => (RuleGroup::Preview, rules::airflow::rules::AirflowDagNoScheduleArgument),
         (Airflow, "301") => (RuleGroup::Preview, rules::airflow::rules::Airflow3Removal),
         (Airflow, "302") => (RuleGroup::Preview, rules::airflow::rules::Airflow3MovedToProvider),
+        (Airflow, "312") => (RuleGroup::Preview, rules::airflow::rules::Airflow3SuggestedToMoveToProvider),
 
         // perflint
         (Perflint, "101") => (RuleGroup::Stable, rules::perflint::rules::UnnecessaryListCast),

crates/ruff_linter/src/rules/airflow/helpers.rs

@@ -15,6 +15,21 @@ pub(crate) enum Replacement {
     },
 }
 
+#[derive(Debug, Eq, PartialEq)]
+pub(crate) enum ProviderReplacement {
+    ProviderName {
+        name: &'static str,
+        provider: &'static str,
+        version: &'static str,
+    },
+    SourceModuleMovedToProvider {
+        name: String,
+        module: &'static str,
+        provider: &'static str,
+        version: &'static str,
+    },
+}
+
 pub(crate) fn is_guarded_by_try_except(
     expr: &Expr,
     replacement: &Replacement,

crates/ruff_linter/src/rules/airflow/mod.rs

@@ -22,6 +22,7 @@ mod tests {
     #[test_case(Rule::Airflow3Removal, Path::new("AIR301_airflow_plugin.py"))]
     #[test_case(Rule::Airflow3Removal, Path::new("AIR301_context.py"))]
     #[test_case(Rule::Airflow3MovedToProvider, Path::new("AIR302.py"))]
+    #[test_case(Rule::Airflow3SuggestedToMoveToProvider, Path::new("AIR312.py"))]
     fn rules(rule_code: Rule, path: &Path) -> Result<()> {
         let snapshot = format!("{}_{}", rule_code.noqa_code(), path.to_string_lossy());
         let diagnostics = test_path(

crates/ruff_linter/src/rules/airflow/rules/mod.rs

@@ -1,9 +1,11 @@
 pub(crate) use dag_schedule_argument::*;
 pub(crate) use moved_to_provider_in_3::*;
 pub(crate) use removal_in_3::*;
+pub(crate) use suggested_to_move_to_provider_in_3::*;
 pub(crate) use task_variable_name::*;
 
 mod dag_schedule_argument;
 mod moved_to_provider_in_3;
 mod removal_in_3;
+mod suggested_to_move_to_provider_in_3;
 mod task_variable_name;