Exempt unittest context methods for SIM115 rule #16439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AlexWaygood
reviewed
Feb 28, 2025
crates/ruff_linter/src/rules/flake8_simplify/rules/open_file_with_context_handler.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_simplify/rules/open_file_with_context_handler.rs
Outdated
Show resolved
Hide resolved
crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM115.py
Outdated
Show resolved
Hide resolved
co-authored-by: Alex Waygood <[email protected]>
adamchainz
force-pushed
the
adamchainz/sim115
branch
from
64793c0 to
1288243
Compare
AlexWaygood
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exempt calls to the three context methods in unittest, allowing some false positives where identical method names are used.
Closes #16438.
Test Plan
Added test cases to Python file, updated snapshots.