[RUF] Add rule to detect empty literal in deque call (RUF025)
#15104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
reviewed
Dec 23, 2024
Member
MichaReiser
left a comment
MichaReiser
left a comment
There was a problem hiding this comment.
Nice thanks
I think we have to rename the rule to avoid naming collisions with flake8-comprehensions in the future
...s/ruff_linter/src/rules/flake8_comprehensions/rules/unnecessary_literal_within_deque_call.rs
Outdated
Show resolved
Hide resolved
...s/ruff_linter/src/rules/flake8_comprehensions/rules/unnecessary_literal_within_deque_call.rs
Outdated
Show resolved
Hide resolved
dhruvmanila
added
rule
Contributor
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| RUF025 | 3 | 3 | 0 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
MichaReiser
changed the title
flake8_comprehensions] Add rule to detect empty literal in deque callRUF] Add rule to detect empty literal in deque call (RUF025)
dcreager
added a commit
that referenced
this pull request
Jan 3, 2025
* main: [`ruff`] Avoid reporting when `ndigits` is possibly negative (`RUF057`) (#15234) Attribute panics to the mdtests that cause them (#15241) Show errors for attempted fixes only when passed `--verbose` (#15237) [`RUF`] Add rule to detect empty literal in deque call (`RUF025`) (#15104) TD003: remove issue code length restriction (#15175) Preserve multiline implicit concatenated strings in docstring positions (#15126) [`pyflakes`] Ignore errors in `@no_type_check` string annotations (`F722`, `F821`) (#15215) style(AIR302): rename removed_airflow_plugin_extension as check_airflow_plugin_extension (#15233) [`pylint`] Re-implement `unreachable` (`PLW0101`) (#10891) refactor(AIR303): move duplicate qualified_name.to_string() to Diagnostic argument (#15220) Misc. clean up to rounding rules (#15231) Avoid syntax error when removing int over multiple lines (#15230) Migrate renovate config (#15228) Remove `Type::tuple` in favor of `TupleType::from_elements` (#15218)
|
I opened an issue with this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The idea comes from #13515. When you create a
collections.deque, it will be empty by default. You can pass an iterable as the first argument, but if the iterable is empty, then it is unnecessary.Becomes:
Test plan
I added test cases for most of the obvious ways this should apply.