Skip to content

[flake8-pie] Mark fix as unsafe if the following statement is a string literal (PIE790) #14393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2024
Merged

[flake8-pie] Mark fix as unsafe if the following statement is a string literal (PIE790) #14393

merged 3 commits into from
Nov 18, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #12616.

Test Plan

cargo nextest run and cargo insta test.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh added the fixes Related to suggested fixes for violations label Nov 18, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) November 18, 2024 02:24
@charliermarsh charliermarsh merged commit 0a27c9d into astral-sh:main Nov 18, 2024
19 checks passed
@InSyncWithFoo InSyncWithFoo deleted the PIE790 branch November 18, 2024 02:31
@BrewTestBot BrewTestBot mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PIE790 fix can make non-docstrings into docstrings
2 participants
@InSyncWithFoo @charliermarsh