format: different behavior with black for `hug_parens_with_braces_and_square_brackets` and generators

[trim21]

I'm using ruff format with --preview enable, and it generate different output in this case.

ruff:

import shutil
import asyncio


async def main():
    by_path = {}
    loop = asyncio.get_event_loop()

    if loop:
        value = await asyncio.gather(
            *(
                loop.run_in_executor(None, lambda pp: (pp, shutil.disk_usage(pp).free), p)
                for p in by_path
            )
        )
        return value

    return None

black:

import shutil
import asyncio


async def main():
    by_path = {}
    loop = asyncio.get_event_loop()

    if loop:
        value = await asyncio.gather(*(
            loop.run_in_executor(None, lambda pp: (pp, shutil.disk_usage(pp).free), p)
            for p in by_path
        ))
        return value

    return None

This is not listed in "Known Deviations from Black", is this unexpected behavoir?

pyproject.toml

[tool.black]
line-length = 100
target-version = ['py311']
#future = true

unstable = true
preview = true

[tool.ruff]
cache-dir = ".venv/.cache/ruff"
line-length = 100
target-version = 'py311'

exclude = ['dist', '.venv']

[tool.ruff.format]
preview = true

[153957]

I think this is related; psf/black#3964 (comment)
And this in black is the part which may be missing in ruff: psf/black#3992

[trim21]

title of this issue is not very accurate and I don't know how black call this feature...

[153957]

I think it is called hug_parens_with_braces_and_square_brackets:
#9945 (comment)

[trim21]

I think it is called hug_parens_with_braces_and_square_brackets: #9945 (comment)

thanks

[dhruvmanila]

It seems like we don't consider generator to be huggable:

ruff/crates/ruff_python_formatter/src/expression/mod.rs

Line 1126 in 5bde6a0

| Expr::Generator(_)

I'm not sure if it's intentional or not but Micha might be able to provide more context on this once he's back from his PTO.

Although it does seem that a tuple expression is huggable, so I'd say that the generator should probably be as well.

[MichaReiser]

This is not listed in "Known Deviations from Black", is this unexpected behavior?

We don't track differences for preview styles because both Black's and Ruff's preview styles are in flux, making it difficult to track the differences over time.

I'm not sure if it's intentional or not but Micha might be able to provide more context on this once he's back from his PTO.

I don't think this is intentional. The only thing we need to be mindful of is that generator parentheses in call expressions are optional. Meaning, we should only hug if the generator already has parentheses (the logic must be in sync with the parentheses logic in FormatExprGenerator)

[trim21]

I encounter a case that ruff didn't format this code, this look similar, is this same issue ?

(blacked, version 2024)

class TestCompareTestFunctions(unittest.TestCase):
    def test_read_string_or_entries(self):
        with self.assertRaises(cmptest.TestError) as assctxt:
            cmptest.read_string_or_entries(
                """

              2014-01-27 * "UNION MARKET"
                Liabilities:US:Amex:BlueCash    -22.02 USD
                Expenses:Food:Grocery

            """
            )
        self.assertRegex(str(assctxt.exception), "may not use interpolation")

or this:

class TestCompareTestFunctions(unittest.TestCase):
    def test_read_string_or_entries(self):
        with self.assertRaises(cmptest.TestError) as assctxt:
            cmptest.read_string_or_entries("""

              2014-01-27 * "UNION MARKET"
                Liabilities:US:Amex:BlueCash    -22.02 USD
                Expenses:Food:Grocery

            """)
        self.assertRegex(str(assctxt.exception), "may not use interpolation")

[MichaReiser]

@trim21 I suspect your example is https://docs.astral.sh/ruff/formatter/black/#call-expressions-with-a-single-multiline-string-argument although I don't fully understand what's the input

[trim21]

@trim21 I suspect your example is https://docs.astral.sh/ruff/formatter/black/#call-expressions-with-a-single-multiline-string-argument although I don't fully understand what's the input

oh, thanks i miss this