Allow multiple self-dependencies #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In uv, we don't use the `DependencyConstraints` map, but pass in the dependencies through an iterator. This means there can be duplicate dependencies in the input. This would previously make `merge_dependents` panic if a package dependent on itself twice with the same range: ```toml [package] name = "foo" version = "0.1.0" dependencies = ["foo", "foo"] ``` The fix is to ignore self-dependencies when merging dependents, given that they are always trivially true or trivially false.
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
konstin
added a commit
to astral-sh/uv
that referenced
this pull request
May 9, 2025
The fix itself and its documentation live in pubgrub: astral-sh/pubgrub#44 Fixes #13344
| // meaning it can't hit this branch, which requires two self-dependencies. | ||
| if p1 == p2 { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
So like, elsewhere, we'll be able to immediately convert each of these dependencies to True or False, since they're trivial -- no merging required?
There was a problem hiding this comment.
Yes, each partial solution immediately knows their value (while not filtering self-dependencies out earlier keeps error reporting etc. consistent)
charliermarsh
added a commit
to astral-sh/uv
that referenced
this pull request
May 13, 2025
The fix itself and its documentation live in pubgrub: astral-sh/pubgrub#44 Fixes #13344 --------- Co-authored-by: Charlie Marsh <[email protected]>
konstin
added a commit
that referenced
this pull request
May 23, 2025
In uv, we don't use the `DependencyConstraints` map, but pass in the dependencies through an iterator. This means there can be duplicate dependencies in the input. This would previously make `merge_dependents` panic if a package dependent on itself twice with the same range: ```toml [package] name = "foo" version = "0.1.0" dependencies = ["foo", "foo"] ``` The fix is to ignore self-dependencies when merging dependents, given that they are always trivially true or trivially false.
konstin
added a commit
that referenced
this pull request
Aug 27, 2025
In uv, we don't use the `DependencyConstraints` map, but pass in the dependencies through an iterator. This means there can be duplicate dependencies in the input. This would previously make `merge_dependents` panic if a package dependent on itself twice with the same range: ```toml [package] name = "foo" version = "0.1.0" dependencies = ["foo", "foo"] ``` The fix is to ignore self-dependencies when merging dependents, given that they are always trivially true or trivially false.
konstin
added a commit
that referenced
this pull request
Oct 1, 2025
In uv, we don't use the `DependencyConstraints` map, but pass in the dependencies through an iterator. This means there can be duplicate dependencies in the input. This would previously make `merge_dependents` panic if a package dependent on itself twice with the same range: ```toml [package] name = "foo" version = "0.1.0" dependencies = ["foo", "foo"] ``` The fix is to ignore self-dependencies when merging dependents, given that they are always trivially true or trivially false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In uv, we don't use the
DependencyConstraintsmap, but pass in the dependencies through an iterator. This means there can be duplicate dependencies in the input. This would previously makemerge_dependentspanic if a package dependent on itself twice with the same range:The fix is to ignore self-dependencies when merging dependents, given that they are always trivially true or trivially false.