Skip to content

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Nov 16, 2023

No description provided.

@zanieb zanieb merged commit c678c5a into main Nov 16, 2023
echo ::set-output name=LAST_PERMA_NUMBER::$(\
git ls-remote --tags --refs --sort="v:refname" \
https://github.com/zanieb/pubgrub.git | grep "tags/perma-" | tail -n1 | sed 's/.*\/perma-//' \
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do the slightly nicer echo {name}={value} >> "$GITHUB_OUTPUT" now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good note I was about to comment here that I should change to the new syntax.

I copied this from some code I wrote a long time ago to pull versions from tags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from some code I wrote a long time ago to pull versions from tags.

We have the exact same GHA development workflow. :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3

zanieb added a commit to astral-sh/uv that referenced this pull request Nov 16, 2023
A fork will let us stay up to date with the upstream while replaying our
work on top of it.

I expect a similar workflow to the RustPython-Parser fork we maintained,
except that I wrote an automation to create tags for each commit on the
fork (astral-sh/pubgrub#2) so we do not need to
manually tag and document each commit.

To update with the upstream:

- Rebase our fork's `main` branch on top of the latest changes in
upstream's `dev` branch
- Force push, overwriting our `main` branch history
- Change the commit hash here to the last commit on `main` in our fork

Since we automatically tag each commit on the fork, we should never lose
the commits that are dropped from `main` during rebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants