Widen isInstanceOf assert to operate on nullable types
#554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Oct 28, 2024
evant
reviewed
Oct 28, 2024
Collaborator
evant
left a comment
evant
left a comment
There was a problem hiding this comment.
Do we also want isNotInstanceOf to take null for the same reason?
This behavior brings it more line with how 'is' behaves in the language.
JakeWharton
force-pushed
the
jw.isInstanceOf-on-null.2024-10-28
branch
from
db3c671 to
9cef28d
Compare
Contributor
Author
Done! I'm not sure how useful this is in practice, but consistency with the positive assertion and the language makes sense. |
evant
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior brings it more line with how 'is' behaves in the language.
Refs #393. Refs #550.