Razor.Language API polish

[NTaylorMullen]

General

• Make DocumentClassifierPassBase.TargetExtensions private. - @NTaylorMullen
• IRazorEngineBuilder.DesignTime should be getter only. - @NTaylorMullen
• RazorCSharpDocument.GeneratedCode should be renamed to Code. - @NTaylorMullen - Unimportant/too cross-cutting for repos.
• Rename RazorEngineFeatureBase.ThrowForMissingEngineDependency to ThrowForMissingFeatureDependency - @NTaylorMullen
• Rename RazorEnginePhaseBase.ThrowForMissingEngineDependency to ThrowForMissingFeatureDependency - @NTaylorMullen
• Find all instances of base / path and rename them to FilePath / BasePath - @ajaybhargavb
• Abstractify ICodeTargetBuilder. - @ajaybhargavb
• IntermediateNodeWalker should be indexable - @ajaybhargavb
• Do a pass on all IntermediateNodes and cross-check the verbosity of their properties. They should be consistent which may mean having more verbose properties. - @ajaybhargavb
• Unnest IntermediateToken.TokenKind - @ajaybhargavb
• Make TagHelperIntermediateNode.TagHelpers an IList - @ajaybhargavb

HtmlConventions.InvalidNonWhitespaceHtmlCharacters - @ajaybhargavb

• Make internal.
• Make non-hashset.

LineMapping - @NTaylorMullen

• Rename to SourceMapping.
• Remove == and != operators.

RazorParserOptions - @NTaylorMullen

• Add CreateDesignTime method
• Rename ParseOnlyLeadingDirectives => ParseLeadingDirectives

RazorParserOptionsBuilder - @NTaylorMullen

• DesignTime should be getter only.
• Rename ParseOnlyLeadingDirectives => ParseLeadingDirectives

TagHelperBinding - @NTaylorMullen

• Attributes should be IReadOnlyList if it makes sense.
• GetBoundRules should return IReadOnlyList if it makes sense.

TagHelper descriptors in general - @NTaylorMullen

• See if TagHelperDescriptor.AllowedChildTags can be IReadOnlyList
• See if TagHelperDescriptor.BoundAttributes can be IReadOnlyList
• See if TagHelperDescriptor.TagMatchingRules can be IReadOnlyList
• See if TagMatchingRuleDescriptor.Attributes can be IReadOnlyList
• See if TagMatchingRuleDescriptor.Attributes can be IReadOnlyList

[NTaylorMullen]

When working on one of these lets put our name next to the items or item header so we don't duplicate work.

[NTaylorMullen]

afa61e7
87a5435
b68290d
cb40da4
aspnet/Mvc@1be7960
c34a99e
bba508c
d891fae
d891fae

[ajaybhargavb]

11c5293
6fdd4d6
d6e892b
aspnet/Mvc@8bc4d7b
aspnet/Mvc@05f5d59
49eab41
267b3fa
b70815e