Skip to content

chore: fix release_prep reference to snippet in e2e/smoke/WORKSPACE #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

chore: fix release_prep reference to snippet in e2e/smoke/WORKSPACE #821

merged 1 commit into from
Jul 4, 2025

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jul 4, 2025 •
edited
Loading

Most likely broken from 264f5bd

See failure: https://github.com/aspect-build/rules_ts/actions/runs/16079953644/job/45382823925

Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce: guess

@jbedard jbedard requested review from alexeagle and dzbarsky July 4, 2025 19:46
@jbedard jbedard enabled auto-merge (rebase) July 4, 2025 19:46
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Jul 4, 2025 •
edited
Loading

Test

All tests were cache hits

182 tests (100.0%) were fully cached saving 8s.

Test

e2e/external_dep

All tests were cache hits

6 tests (100.0%) were fully cached saving 341ms.

Test

e2e/smoke

All tests were cache hits

2 tests (100.0%) were fully cached saving 71ms.

Test

e2e/test

All tests were cache hits

182 tests (100.0%) were fully cached saving 8s.

Test

e2e/worker

All tests were cache hits

6 tests (100.0%) were fully cached saving 325ms.

Buildifier      Format

@dzbarsky dzbarsky mentioned this pull request Jul 4, 2025
Closed
@jbedard jbedard merged commit 9bc7a3a into aspect-build:main Jul 4, 2025
14 checks passed
@jbedard jbedard deleted the ci-release-e2e branch July 4, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzbarsky dzbarsky dzbarsky approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @dzbarsky