feat: support custom progress messages #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alexeagle
reviewed
May 15, 2025
devversion
force-pushed
the
custom-progress
branch
from
6f0502f to
f5cf62f
Compare
devversion
force-pushed
the
custom-progress
branch
from
f5cf62f to
c1cb346
Compare
alexeagle
approved these changes
May 15, 2025
For Angular we fully rely on `ts_project` just with a custom `tsc` executable. We would like to have better distinction between Angular or TypeScript targets. It seems like it would be useful to control the progress message. This would also allow better distinction when e.g. compiling with a different configuration. e.g. we use a transition for Angular to compile with a different compilation mode when shipping to npm
devversion
force-pushed
the
custom-progress
branch
from
c1cb346 to
b290f72
Compare
|
@alexeagle ops, sorry. Pushed |
|
@devversion FWIW I've been experimenting with dropping the docs-checked-in pattern because it's always this last oops step for contributors, and no easy way to just "accept fix" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Angular we fully rely on
ts_projectjust with a customtscexecutable. We would like to have better distinction between Angular or TypeScript targets. It seems like it would be useful to control the progress message.This would also allow better distinction when e.g. compiling with a different configuration. e.g. we use a transition for Angular to compile with a different compilation mode when shipping to npm.