Skip to content

refactor: do not re-copy_to_bin ts_project(srcs) #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

refactor: do not re-copy_to_bin ts_project(srcs) #803

merged 1 commit into from
Apr 29, 2025

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Apr 29, 2025

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Apr 29, 2025 •
edited
Loading

Test

All tests were cache hits

173 tests (100.0%) were fully cached saving 12s.

Buildifier      Format

@jbedard jbedard requested review from alexeagle and thesayyn April 29, 2025 00:37
@jbedard jbedard marked this pull request as ready for review April 29, 2025 00:37
@jbedard jbedard merged commit f332843 into aspect-build:main Apr 29, 2025
19 checks passed
@jbedard jbedard deleted the no-double-copy branch April 29, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@thesayyn thesayyn Awaiting requested review from thesayyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @alexeagle