Skip to content

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Mar 13, 2025

Fix #781


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Include tsconfig deps when invoking tsc even when ts_project(isolated_typecheck).

Test plan

  • New test cases added

Copy link

aspect-workflows bot commented Mar 13, 2025

Test

1 test target passed

Targets
//examples/tsconfig_types:test [k8-fastbuild] 46ms

Total test execution time was 46ms. 174 tests (99.4%) were fully cached saving 12s.


Buildifier      Format

@jbedard jbedard force-pushed the isolated-tsconfig-deps branch from a5ce8ee to ce36163 Compare March 14, 2025 00:45
@jbedard jbedard requested review from alexeagle and thesayyn March 14, 2025 00:46
@jbedard jbedard force-pushed the isolated-tsconfig-deps branch from ce36163 to 7ed4b5e Compare March 14, 2025 00:47
@jbedard jbedard marked this pull request as ready for review March 14, 2025 01:51
@jbedard jbedard merged commit 0649b87 into aspect-build:main Mar 17, 2025
18 checks passed
@jbedard jbedard deleted the isolated-tsconfig-deps branch March 17, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: isolated_typecheck does not include transitive ts_config deps when tsc invoked
2 participants