Skip to content

Conversation

walkerburgin
Copy link
Contributor

Add support to ts_project() for assets that are generated directly into the outDir.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Test plan

  • Covered by existing test cases
  • New test cases added

Before this PR the ts-root-out_outputs_test fails because the outDir gets duplicated (root-out/root-out):

==================== Test output for //examples/assets:ts-root-out_outputs_test:
3c3
< examples/assets/root-out/metadata/generated_metadata.json
---
> examples/assets/root-out/root-out/metadata/generated_metadata.json
FAIL: files "examples/assets/_expected_ts-root-out_outputs_test.txt" and "examples/assets/_ts-root-out_outputs_test_outputs.txt" differ.
================================================================================

Copy link

aspect-workflows bot commented Mar 12, 2025

Test

1 test target passed

Targets
//examples/assets:ts-root-out_outputs_test [k8-fastbuild] 28ms

Total test execution time was 28ms. 174 tests (99.4%) were fully cached saving 12s.


Buildifier      Format

@jbedard jbedard self-requested a review March 12, 2025 19:25
@jbedard jbedard merged commit d82d330 into aspect-build:main Mar 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants