Skip to content

[Bug]: pre-commit advice in CONTRIBUTING.md is at odds with the actual state of the repo #826

@dws

Description

@dws

What happened?

The advice in CONTRIBUTING.md is to run pre-commit on your contributions.
However, when I ran pre-commit run --all-files it found formatting problems in 45 files that were unrelated to my contribution (for #825).
So,

  1. Is the advice in CONTRIBUTING.md correct?
  2. Are the formatting checks being enforced by your CI?
  3. Do you want a PR consisting only of the formatting changes performed by pre-commit run --all-files?

Version

Development (host) and target OS/architectures: MacOS Sequoia 15.5 / amd64

Output of bazel --version:

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: HEAD

Language(s) and/or frameworks involved:

How to reproduce

pre-commit run --all-files

Any other information?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions