refactor: remove docgen #304
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
rm_docgen
branch
4 times, most recently
from
6af26cc to
ed07e5e
Compare
It's annoying to maintain a submodule for this. It's also not good ergonomics for contributors, who send a docs update and then get a red PR because doc strings appear in two places. Ideally we'd have Marvin just amend the PR with an extra commit, but that feature isn't ready yet.
alexeagle
force-pushed
the
rm_docgen
branch
2 times, most recently
from
eae58f1 to
22bd7e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's annoying to maintain a submodule for this. It's also not good ergonomics for contributors, who send a docs update and then get a red PR because doc strings appear in two places. Ideally we'd have Marvin just amend the PR with an extra commit, but that feature isn't ready yet.
Also use
bzl_libraryfrom aspect_bazel_lib to workaround bazelbuild/bazel-skylib#568 (note that this red PR showed we already broke it https://github.com/alexeagle/doc.bzl/actions/runs/16888423012)