Skip to content

refactor: only use underlying rule where required #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2023
Merged

refactor: only use underlying rule where required #162

merged 1 commit into from
Feb 9, 2023

Conversation

alexeagle
Copy link
Member

Also use boolean rather than string where possible.

@alexeagle
refactor: only use underlying rule where required
c1dc26b 
Also use boolean rather than string where possible.
gregmagolan
gregmagolan approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@alexeagle alexeagle merged commit cc65c96 into main Feb 9, 2023
@alexeagle alexeagle deleted the srcmaps branch February 9, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

@jbedard jbedard Awaiting requested review from jbedard

@mattem mattem Awaiting requested review from mattem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @gregmagolan