js_image_layer allow configurable directory/file permissions #2313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configurable file and directory permissions to js_image_layer
The changes implement two new attributes:
Previously, these permission modes were hardcoded in the implementation. Now users can customize them when creating image layers, while maintaining the same default behavior for backward compatibility.
Changes are visible to end-users: yes/no
Suggested Release Notes:
directory_mode
andfile_mode
tojs_image_layer
— specify octal permissions for directories and files in generated layer tarballs (defaults:0755
for directories,0555
for files`).Test plan
Manual testing can be done via JS oci image; inspect the filesystem to ensure that the 'data' attribute directories have the appropriate permissions applied.