Skip to content

Conversation

keith
Copy link
Contributor

@keith keith commented Jul 25, 2025

If users don't have locales setup correctly, just having this is the
archive makes the download fail. If the build doesn't otherwise have
non-ascii characters the fact that their locales are incorrect doesn't
matter besides this failure:

ERROR: Skipping '//...': error loading package under directory '': no such package '@@aspect_rules_js+//js': java.io.IOException: Error extracting .../aspect_rules_js+/temp7219254014548800952/rules_js-v2.3.8.tar.gz to .../aspect_rules_js+/temp7219254014548800952: [unix_jni.cc:281] .../aspect_rules_js+/js/private/test/image/non_ascii/empty empty.?? (No such file or directory)

If users don't have locales setup correctly, just having this is the
archive makes the download fail. If the build doesn't otherwise have
non-ascii characters the fact that their locales are incorrect doesn't
matter besides this failure:

```
ERROR: Skipping '//...': error loading package under directory '': no such package '@@aspect_rules_js+//js': java.io.IOException: Error extracting .../aspect_rules_js+/temp7219254014548800952/rules_js-v2.3.8.tar.gz to .../aspect_rules_js+/temp7219254014548800952: [unix_jni.cc:281] .../aspect_rules_js+/js/private/test/image/non_ascii/empty empty.?? (No such file or directory)
```
Copy link

aspect-workflows bot commented Jul 25, 2025

Test

All tests were cache hits

216 tests (100.0%) were fully cached saving 33s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 539ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 184ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 533ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 630ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 268ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 269ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 31ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 324ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

52 tests (100.0%) were fully cached saving 6s.


Test

e2e/pnpm_workspace

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

15 tests (100.0%) were fully cached saving 2s.


Test

e2e/repo_mapping

All tests were cache hits

3 tests (100.0%) were fully cached saving 410ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 137ms.


Test

e2e/runfiles

All tests were cache hits

1 test (100.0%) was fully cached saving 80ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 114ms.


Buildifier      Format

@jbedard jbedard changed the title Add non_ascii directory to export-ignore chore: add non_ascii directory to export-ignore Jul 25, 2025
@jbedard jbedard merged commit 8a818b7 into aspect-build:main Jul 25, 2025
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants