Skip to content

add data runfiles to js_run_devserver sandbox #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

add data runfiles to js_run_devserver sandbox #2241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion js/private/js_run_devserver.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,13 @@ def _js_run_devserver_impl(ctx):
include_npm_sources = ctx.attr.include_npm_sources,
)]

default_data_runfiles = [target[DefaultInfo].default_runfiles.files for target in ctx.attr.data]

# The .to_list() calls here are intentional and cannot be avoided; they should be small sets of
# files as they only include direct npm links (node_modules/foo) and the package store tree
# artifacts those symlinks point to (node_modules/.aspect_rules_js/[email protected]/node_modules/foo)
data_files = []
for f in depset(transitive = transitive_runfiles + [dep.files for dep in ctx.attr.data]).to_list():
for f in depset(transitive = transitive_runfiles + [dep.files for dep in ctx.attr.data] + default_data_runfiles).to_list():
if "/.aspect_rules_js/" in f.path:
# Special handling for package store deps; we only include 1st party deps since copying
# all 3rd party node_modules over is expensive for typical graphs
Expand Down