[Bug]: new js_image_layer code breaks backwards compatability with rules_nodejs v5

[Aghassi]

What happened?

Upgrading to the latest minor 3.5 from 3.2 I find that js_image_layer no longer resolves node from the the toolchain correctly for users on rules_nodejs v5. I understand there are some work arounds in other areas and I understand that ideally everyone is on v6. However, we have not fully migrated to rules_nodejs v6 because we have to migrate existing apps to rules_js which is yet to happen.

I made PR #2186 to try and addres the issue, but it internally broke because the layer doesn't build on macos correctly but it does on linux. ON macos it resolves the linux binary.

Version

Development (host) and target OS/architectures:

Output of bazel --version: 7.x

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file: 3.5.2

Language(s) and/or frameworks involved:
JS

How to reproduce

Honestly just reach out to me and I'm happy to pair, I don't know how to repro outside of my companies code off hand :)

Any other information?

No response

[thesayyn]

We do get node in exec configuration so i am not sure whats happening here. https://github.com/aspect-build/rules_js/pull/2186/files#diff-18b1b3b0eab8026048eee336ba4281b5560043e23b3b2923eb0bb3d2a8f25383L600

[Aghassi]

it could be do to my patch which I see @jbedard fixed in my PR

[Aghassi]

Let me try again with the new fix and get back to you

[Aghassi]

With the fix landed it works. I have a separate issue with running with container_test that I need to narrow down when running on macOS. It keeps grabbing the linux node binary

[jbedard]

Should we log a separate issue for that?

[Aghassi]

Yes let's do that

[Aghassi]

Here is the new issue #2206