crlf & better cli diagnostics

[peakschris]

bsdtar in libarchive does not support reading an mtree file with CRLF endings

I have submitted libarchive/libarchive#2717 - but this may take some time to upstream. In the meantime have added a patch here which adds this CRLF support. This fixes bsdtar for usage in rules_oci.

One change:

• CRLF endings are tolerated when reading mtree spec

[alexeagle]

I think this repo isn't the best place to add the patch, as it's layered purely as a continuous delivery pipeline for the BCR module. Could we add the patch to BCR instead?
As another benefit, this way anyone building from source will have it functional on Windows as well.

And yes, I'd prefer to have the PR for the minimal patch to accept line endings, just to reduce our divergence from what might end up landing upstream.

[peakschris]

@alexeagle sure - I've never submitted to BCR before - what's the process? Fork the repo and submit a PR as normal?

[alexeagle]

Yup, similar to other PRs to that folder - bazelbuild/bazel-central-registry#4649 introduced the current "buggy" version; bazelbuild/bazel-central-registry#3225 is an example of updating the same version to fix a windows issue.

[peakschris]

bazelbuild/bazel-central-registry#5482

[alexeagle]

I'm okay with landing it here

[alexeagle]

Thanks for the fix! Let's make Windows work :)

[peakschris]

Awesome! Could you push a new release to BCR?

[peakschris]

@alexeagle fyi libarchive/libarchive#2717 is merged so we are just waiting for a new libarchive release now

[alexeagle]

Thanks, eventually the release train will leave the station