Skip to content

Conversation

@shelegdmitriy
Copy link
Member

No description provided.

@shelegdmitriy shelegdmitriy requested a review from Copilot April 18, 2025 14:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the project structure to simplify configuration and update module references accordingly.

  • Updated the Vite configuration to exclude the examples directory for type generation.
  • Adjusted export and import paths in library and example files to reflect the new project layout.
  • Updated the main HTML entry point to load the script from the new examples location.

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

File Description
vite.config.ts Updated DTS plugin's exclusion list to simplify type generation.
src/lib/main.ts Modified the export path for the Map module to reflect the new structure.
index.html Changed the script reference to align with the relocated example entry.
examples/App.tsx Updated the import path for MapView to match the restructured library path.
Files not reviewed (1)
  • tsconfig.app.json: Language not supported
Comments suppressed due to low confidence (3)

vite.config.ts:14

  • Verify that excluding the entire 'examples' directory from DTS generation does not inadvertently skip essential type definitions needed for production code.
exclude: ['examples'],

src/lib/main.ts:1

  • Confirm that the new export path correctly resolves to the intended module following the project reorganization.
export * from './Map';

examples/App.tsx:2

  • Double-check that the updated relative path accurately locates the MapView component after the directory changes.
import { MapView } from '../src/lib/Map';

@shelegdmitriy shelegdmitriy merged commit 6b37fff into main Apr 18, 2025
1 check passed
@shelegdmitriy shelegdmitriy deleted the chore/simplify-project-structure branch April 18, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants