Skip to content

Conversation

albinkc
Copy link
Contributor

@albinkc albinkc commented Jun 5, 2025

the --git option does git init && git add . && git commit -m "Initial commit"

Contributor checklist

Leave anything that you believe does not apply unchecked.

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

dependabot bot and others added 2 commits June 5, 2025 11:28
…project#294)

Bumps the production-dependencies group with 1 update: [spitfire](https://github.com/elixir-tools/spitfire).


Updates `spitfire` from 0.2.0 to 0.2.1
- [Release notes](https://github.com/elixir-tools/spitfire/releases)
- [Changelog](https://github.com/elixir-tools/spitfire/blob/main/CHANGELOG.md)
- [Commits](elixir-tools/spitfire@v0.2.0...v0.2.1)

---
updated-dependencies:
- dependency-name: spitfire
  dependency-version: 0.2.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: production-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@zachdaniel
Copy link
Contributor

Nice 👍

  1. lets add an integration test for this, that uses System.cmd to run this in a tmp directory.
  2. lets make that initial message include a list of what was installed initially

@zachdaniel
Copy link
Contributor

Let's add 🔥 to the beginning of the initial commit too 😎

@albinkc
Copy link
Contributor Author

albinkc commented Jun 10, 2025

Nice 👍

1. lets add an integration test for this, that uses `System.cmd` to run this in a tmp directory.

2. lets make that initial message include a list of what was installed initially

so I've semi-vibe coded an integration test, but not sure how to do the second one 😶

@zachdaniel
Copy link
Contributor

For now, lets just add 🔥 initial commit 🔥

We can follow up with the other idea if we want

@albinkc
Copy link
Contributor Author

albinkc commented Jun 14, 2025

Have added the flames again (messed up something when git pushing).
I think need to update CI to run mix test inside of installer/ (don't want to mess this up)
Please review.

test "initializes git repository and creates initial commit", %{tmp_dir: tmp_dir} do
unless git_available?() do
:ok
else
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well want to remove inspects etc.

@zachdaniel
Copy link
Contributor

Had one comments. For the CI thing can you confirm the tests all pass locally? I can set up CI after we merge.

@zachdaniel zachdaniel merged commit 9702826 into ash-project:main Jul 15, 2025
@zachdaniel
Copy link
Contributor

Merging and adding some finishing touches 😄 This will become the default behavior, so it will actually be --no-git if you don't want it.

@albinkc
Copy link
Contributor Author

albinkc commented Jul 15, 2025

Thanks a ton for picking this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants