-
-
Notifications
You must be signed in to change notification settings - Fork 52
feat: add --git option to igniter.new #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…project#294) Bumps the production-dependencies group with 1 update: [spitfire](https://github.com/elixir-tools/spitfire). Updates `spitfire` from 0.2.0 to 0.2.1 - [Release notes](https://github.com/elixir-tools/spitfire/releases) - [Changelog](https://github.com/elixir-tools/spitfire/blob/main/CHANGELOG.md) - [Commits](elixir-tools/spitfire@v0.2.0...v0.2.1) --- updated-dependencies: - dependency-name: spitfire dependency-version: 0.2.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production-dependencies ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Nice 👍
|
Let's add 🔥 to the beginning of the initial commit too 😎 |
so I've semi-vibe coded an integration test, but not sure how to do the second one 😶 |
For now, lets just add 🔥 initial commit 🔥 We can follow up with the other idea if we want |
Have added the flames again (messed up something when git pushing). |
test "initializes git repository and creates initial commit", %{tmp_dir: tmp_dir} do | ||
unless git_available?() do | ||
:ok | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well want to remove inspects etc.
Had one comments. For the CI thing can you confirm the tests all pass locally? I can set up CI after we merge. |
Merging and adding some finishing touches 😄 This will become the default behavior, so it will actually be |
Thanks a ton for picking this up |
the
--git
option doesgit init && git add . && git commit -m "Initial commit"
Contributor checklist
Leave anything that you believe does not apply unchecked.