Improve SatSolver.simplify_expression/1 #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

zachdaniel merged 1 commit into ash-project:main from maennchen:jm/sat_solver_simplification_improvements

Oct 10, 2025

Contributor

maennchen commented Oct 10, 2025

Changes

Run simplification again if there was a change
Add some more patterns encountered in ash_diagram
Changes are covered by property based tests

Contributor checklist

Leave anything that you believe does not apply unchecked.

I accept the AI Policy, or AI was not used in the creation of this PR.
Bug fixes include regression tests
Chores
Documentation changes
Features include unit/acceptance tests
Refactoring
Update dependencies


          Improve SatSolver.simplify_expression/1

ff91d40

zachdaniel merged commit dc883f5 into ash-project:main

40 of 45 checks passed

maennchen deleted the jm/sat_solver_simplification_improvements branch

October 10, 2025 22:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet