Policy Refactoring #2365
Merged
Policy Refactoring #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the order of statements can have a performance impact. eg. (var and expensive()) will check expensive() only if var is true. If it were reversed, the expensive() check would always be run.
Allows to execute a callback on each node in the given boolean expression to replace the current node. Has a variant with and without an accumulator.
Takes a boolean expression and performs logical constant folding and simplification by removing redundant negations, constants, and tautologies.
Will walk the expression and apply the callback to expand nodes. It will constantly optimize the expression itself to avoid expansion where logical constant folding does no longer require a value.
Allows direct access to the internally used expression
Remove conditions to check which policies might apply and track the decision in the expression instead.
All done in expand_constant instead
All besides true / false are done in simplify_policy_expression
zachdaniel
reviewed
Oct 10, 2025
zachdaniel
approved these changes
Oct 10, 2025
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.