Port fixes #620
Merged
Port fixes #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Align jRuby to v9.3.4.0
* maven-enforcer-plugin to v3.1.0 * maven-compiler-plugin to v3.10.1 * maven-javadoc-plugin to v3.4.1 * maven-jar-plugin to v3.3.0 * maven-surefire-plugin to v3.0.0-M7
Internally eruby option was set as null which caused Asciidoctor to fail with 'Unknown ERB implementation'. The fix sets the option only when a non-empty value is present, delegating to AsciidoctorJ default which is 'erb' (consistent with current docs).
Fix test to accomodate for core change asciidoctor/asciidoctor#4370
Fix test to accomodate for core change asciidoctor/asciidoctor#4370
|
I am doing "Rebase and merge" to keep commit history as aligned as possible with main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting fixes from
mainto2.2.xbranch.For the whole conversation 👉 #617