Skip to content

fix(AnimatedHeader): title not being displayed #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

fix(AnimatedHeader): title not being displayed #363

merged 1 commit into from
Jul 8, 2025

Conversation

araujobarret
Copy link
Contributor

@araujobarret araujobarret commented Jul 8, 2025 •
edited by jira bot
Loading

This PR resolves PBRW-957

Description

  • Removes the scrollViewContentHeight that we checked and it wasn't being correctly calculated, so we decided to skip it since it was causing a bug
  • Adds a side-effect with useAnimatedReaction to update the newly introduced currentScrollYAnimated from past PRs
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-07-08.at.14.22.18.mp4

Co-authored by @MounirDhahri

@araujobarret araujobarret self-assigned this Jul 8, 2025
@artsy-peril artsy-peril bot added Jira Synced Indicates that Peril has connected this PR to Jira Version: Minor A deploy for new features labels Jul 8, 2025
@araujobarret araujobarret changed the title fix: animated reaction to update the tab Y context value fix(AnimatedHeader): title not being displayed Jul 8, 2025
gkartalis
gkartalis approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@gkartalis gkartalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable - I will schedule another qa session since this affects a large portion of the app when we have the rest of launch blocking issues figured out.

Thanks both

@araujobarret araujobarret merged commit 99a8064 into main Jul 8, 2025
6 checks passed
@araujobarret araujobarret deleted the araujobarret/fix/animated-header-title-not-showing branch July 8, 2025 12:47
@artsyit
Copy link
Collaborator

artsyit commented Jul 8, 2025

🚀 PR was released in v17.25.0 🚀

@artsyit artsyit added the released This issue/pull request has been released. label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSltun MrSltun MrSltun approved these changes

@gkartalis gkartalis gkartalis approved these changes

@MounirDhahri MounirDhahri Awaiting requested review from MounirDhahri

Assignees

@araujobarret araujobarret

Labels
Jira Synced Indicates that Peril has connected this PR to Jira released This issue/pull request has been released. Version: Minor A deploy for new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@araujobarret @artsyit @MrSltun @gkartalis