Skip to content

Conversation

@mzikherman
Copy link
Contributor

This seems to be fallout from the graphql* updates, specifically this PR graphql/graphql-js#927

I don't fully understand it yet tbh, but when running printSchema on latest master, I was getting output that would crash when being imported into Emission, with extra quotes around our description fields:

[1] ERROR:
[1] Error loading schema. Expected the schema to be a .graphql or a .json
[1] file, describing your GraphQL server's API. Error detail:
[1] 
[1] GraphQLError: Syntax Error GraphQL request (6:3) Expected Name, found String
[1] 
[1] 5:   input AddAssetToConsignmentSubmissionInput {
[1] 6:   """The type of the asset"""
[1]      ^
[1] 7:   asset_type: String!
[1] 
[1]     at syntaxError (/Users/mzikherman/code/Artsy/emission/node_modules/relay-compiler/node_modules/graphql/error/syntaxError.js:31:15)
[1]     at expect (/Users/mzikherman/code/Artsy/emission/node_modules/relay-compiler/node_modules/graphql/language/parser.js:973:32)

This option fixes it.

@orta
Copy link
Contributor

orta commented Jan 2, 2018

I see, yeah, damn, wish they were doing real semantic versioning.

@orta orta merged commit 011f1fa into master Jan 2, 2018
@orta orta deleted the graphql_comment_fallout branch January 2, 2018 17:24
@alloy
Copy link
Contributor

alloy commented Jan 2, 2018

@orta They do… :/ versions below v1 means anything can change at any time

@orta
Copy link
Contributor

orta commented Jan 2, 2018

Yeah, I meant my SemVer obviously ;)- once it's in production it's 1.0.0

@alloy
Copy link
Contributor

alloy commented Jan 2, 2018

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants