Skip to content

Conversation

@lilyfromseattle
Copy link
Contributor

@lilyfromseattle lilyfromseattle commented Oct 15, 2025

The type of this PR is: FIX
@artsy/diamond-devs

This PR solves DIAM-12

Description

The location input field on collector profile doesn’t have any kind of validation, meaning it takes anything
The placeholder says City, but the user can ignore the autocomplete and enter anything
This leads to weirdness on areas where collector profile locations is surfaced (demand, convos, etc)
Let’s add validation to that form, so we ensure it always corresponds to a valid city.

Before:
https://github.com/user-attachments/assets/603f3ef3-942a-4b60-98ab-840b8be7af39

After:
https://github.com/user-attachments/assets/079b73ce-e6ad-4c32-99cf-b92486499d5e

@lilyfromseattle lilyfromseattle self-assigned this Oct 15, 2025
@lilyfromseattle lilyfromseattle requested review from dzucconi and removed request for dzucconi October 15, 2025 20:13
@relativeci
Copy link

relativeci bot commented Oct 15, 2025

#4612 Bundle Size — 9.51MiB (+0.03%).

fd03aea(current) vs 3308081 main#4605(baseline)

Warning

Bundle contains 35 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#4612
     Baseline
#4605
No change  Initial JS 3.74MiB 3.74MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 43.79% 41.06%
No change  Chunks 102 102
No change  Assets 105 105
No change  Modules 6073 6073
No change  Duplicate Modules 590 590
No change  Duplicate Code 4.35% 4.35%
No change  Packages 298 298
No change  Duplicate Packages 34 34
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#4612
     Baseline
#4605
Regression  JS 9.37MiB (+0.03%) 9.37MiB
No change  Other 144.3KiB 144.3KiB

Bundle analysis reportBranch lilyfromseattle/cp-city-validati...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may cause problems for some edge cases for cities with weird location hierarchies (not even all that edgy: try Brooklyn, NY), but as long as we accept that, lgtm.

@lilyfromseattle
Copy link
Contributor Author

This may cause problems for some edge cases for cities with weird location hierarchies (not even all that edgy: try Brooklyn, NY), but as long as we accept that, lgtm.

fml

Screenshot 2025-10-22 at 4 51 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants