chore: update bid status to show 'live auction' in grey after live auction opens or hide bids info #12583
+131
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxaudo
changed the title
|
Ok. @MrSltun - this is I think good to go. There is still this strange issue with data on staging but for the sake of this PR it's not something that is caused by any of those changes. |
MrSltun
previously approved these changes
Aug 6, 2025
MrSltun
added
the
Squash On Green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for all the auction displays is pretty confusing and probably needs a bigger refactor. But we are not touching it for the most part so I just attempt to do the same we do on Force. Not display bid status for live auctions after the live bidding started. We do have some 'live bidding' prompts in blue across the app - so I kept those but added additional check to see if it is past live open time and in this case just display 'Live auction' in gray in places.
Want to see if specs are passing and after fixing will adjust the PR to proper format
This PR resolves [https://artsyproduct.atlassian.net/browse/EMI-2582]
Description
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.