fix(PBRW-1027): keyboard stays open after saving alert if tap outside during filling the field #12539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a React Native keyboard issue where the keyboard remains open after saving a search alert if the user taps outside the input field during form filling. The fix adds a keyboard dismiss call before processing the form submission.
- Adds
Keyboard.dismiss()to the form submission handler - Imports
Keyboardfrom react-native
| @@ -88,6 +88,8 @@ export const SavedSearchAlertForm: React.FC<SavedSearchAlertFormProps> = (props) | |||
| enableReinitialize: true, | |||
| initialErrors: {}, | |||
| onSubmit: async (values) => { | |||
| Keyboard.dismiss() | |||
There was a problem hiding this comment.
[nitpick] Consider adding error handling or checking if the keyboard is actually open before dismissing it. While Keyboard.dismiss() is generally safe to call, it's better practice to be defensive, especially since you mentioned you couldn't reproduce the issue on Android simulator.
Suggested change
| Keyboard.dismiss() | |
| if (isKeyboardVisible) { | |
| Keyboard.dismiss() | |
| } |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves PBRW-1027
Description
Dismiss keyboard before proceeding with request and navigation
I cannot reproduce the issue on my Android simulator, but this additional
Keyboard.dismiss()should solve the issuePR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.